Skip to content

fix: 상단 border 삭제#164

Merged
dasosann merged 7 commits intomainfrom
fix/bottom-sheet
Jan 20, 2026
Merged

fix: 상단 border 삭제#164
dasosann merged 7 commits intomainfrom
fix/bottom-sheet

Conversation

@dasosann
Copy link
Contributor

요약

fix: 상단 border 삭제

구현 사항

  • 앨범생성 바텀모달 올라올때 위에 있는 border 삭제
  • [ ]
  • [ ]
  • [ ]

📸 스크린샷

Need Review

  • ~ 부분 이렇게 구현했어요, 피드백 부탁해요!

Reference

📜 리뷰 규칙

Reviewer는 아래 P5 Rule을 참고하여 리뷰를 진행합니다.
P5 Rule을 통해 Reviewer는 Reviewee에게 리뷰의 의도를 보다 정확히 전달할 수 있습니다.

  • P1: 꼭 반영해주세요 (Comment)
  • P2: 적극적으로 고려해주세요 (Comment)
  • P3: 웬만하면 반영해 주세요 (Comment)
  • P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)
  • P5: 그냥 사소한 의견입니다 (Approve)

@vercel
Copy link

vercel bot commented Jan 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fe Ready Ready Preview, Comment Jan 20, 2026 6:13am

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @dasosann, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 풀 리퀘스트는 앨범 생성 바텀 모달의 시각적 결함을 해결합니다. 기존에는 모달이 아래에서 위로 올라올 때 상단에 원치 않는 테두리가 나타났는데, 이 변경사항은 해당 테두리를 제거하여 사용자 인터페이스의 깔끔함과 일관성을 향상시킵니다.

Highlights

  • UI 개선: 앨범 생성 바텀 모달이 나타날 때 상단에 불필요하게 표시되던 테두리를 제거했습니다. 이는 src/components/ui/drawer.tsx 파일에서 data-[vaul-drawer-direction=bottom]:border-t CSS 클래스를 제거하여 구현되었습니다.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

이번 PR은 Drawer 컴포넌트가 하단에서 나타날 때 상단 테두리가 표시되는 문제를 해결했습니다. data-[vaul-drawer-direction=bottom]:border-t 클래스를 제거하여 의도한 대로 스타일이 잘 수정되었습니다. 추가로, 코드 유지보수성 향상을 위해 export 구문에서 후행 쉼표(trailing comma)를 다시 추가하는 것을 제안합니다. 전반적으로 깔끔한 수정입니다.

DrawerPortal,
DrawerTitle,
DrawerTrigger,
DrawerTrigger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

코드 스타일의 일관성과 향후 유지보수성을 위해 export 구문에서 후행 쉼표(trailing comma)를 유지하는 것이 좋습니다. 후행 쉼표를 사용하면 나중에 새로운 컴포넌트를 export 목록에 추가할 때 git diff가 더 깔끔하게 유지되어 코드 변경 이력을 추적하기 용이해집니다.

Suggested change
DrawerTrigger
DrawerTrigger,

@dasosann dasosann merged commit b9a2932 into main Jan 20, 2026
2 checks passed
@dasosann dasosann deleted the fix/bottom-sheet branch January 20, 2026 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant